Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Compile error: ambiguous reference to overloaded definition #717

Closed
rongou opened this issue Jan 8, 2024 · 5 comments · Fixed by #720
Closed

[BUG] Compile error: ambiguous reference to overloaded definition #717

rongou opened this issue Jan 8, 2024 · 5 comments · Fixed by #720
Assignees
@amahussein
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@rongou
Copy link

rongou commented Jan 8, 2024

Describe the bug
With commit dedc8d7 getting a compilation error:

[ERROR] [Error] /home/rou/src/spark-rapids-tools/core/src/main/scala/org/apache/spark/sql/rapids/tool/util/SortedJProperties.scala:58: ambiguous reference to overloaded definition,
both method putAll in class Properties of type (x$1: java.util.Map[_, _])Unit
and  method putAll in class Hashtable of type (x$1: java.util.Map[_ <: Object, _ <: Object])Unit
match argument types (org.apache.spark.sql.rapids.tool.util.SortedJProperties)

Steps/Code to reproduce bug
Sync to dedc8d7, in the core directory, do a mvn clean test.

Expected behavior
Should compile.

Environment details (please complete the following information)
Using JDK 11.

Additional context

$ java --version
openjdk 11.0.21 2023-10-17
OpenJDK Runtime Environment (build 11.0.21+9-post-Ubuntu-0ubuntu122.04)
OpenJDK 64-Bit Server VM (build 11.0.21+9-post-Ubuntu-0ubuntu122.04, mixed mode, sharing)
@rongou rongou added ? - Needs Triage bug Something isn't working labels Jan 8, 2024
@rongou
Copy link
Author

rongou commented Jan 8, 2024

@amahussein

@amahussein amahussein added the core_tools Scope the core module (scala) label Jan 8, 2024
@amahussein
Copy link
Collaborator

Thanks @rongou !
We should add JDK 11 to .github/workflows/mvn-verify-check.yml to test the commits against different java versions.

@amahussein
Copy link
Collaborator

This looks to be a bug in Scala 2.12 running with JDK 11 scala/bug#10418

@amahussein amahussein mentioned this issue Jan 8, 2024
Merged
@amahussein amahussein self-assigned this Jan 8, 2024
@rongou
Copy link
Author

rongou commented Jan 8, 2024

What's the supported jdk version?

@amahussein
Copy link
Collaborator

What's the supported jdk version?

JDK-8.0

amahussein added a commit that referenced this issue Jan 9, 2024
@amahussein
Fix compilation error with JDK11 (#720)
2883413 
* Fix compilation error with JDK11

Fixes #717

---------

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compilation error with JDK11 amahussein/spark-rapids-tools
2 participants
@rongou @amahussein