[FEA] Make '--platform' argument mandatory in CLI to prevent incorrect behavior #1462
Labels
bug
Something isn't working
user_tools
Scope the wrapper module running CSP, QualX, and reports (python)
Description
The platform detection logic currently relies on the event log file’s protocol (e.g.
s3://, gs://, hdfs://
) to identify the platform. This approach can lead to incorrect platform detection in certain cases:s3://
protocol are always identified as EMR, which is incorrect since Databricks AWS logs can also use S3 storage.file://
protocol are always identified asonprem
. This might not be the actual platform on which the user had run the application.Impact
Incorrect platform detection leads to invalid speedup estimations, as QualX uses platform-specific models for its calculations.
Proposed Change
Until the platform detection logic is improved, make the
--platform
argument mandatory. This ensures users explicitly specify the platform, avoiding incorrect behavior.The text was updated successfully, but these errors were encountered: