Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Followup: Make '--platform' argument mandatory in CLI to prevent incorrect behavior #1472

Closed
parthosa opened this issue Dec 19, 2024 · 0 comments · Fixed by #1473
Closed

[BUG] Followup: Make '--platform' argument mandatory in CLI to prevent incorrect behavior #1472

parthosa opened this issue Dec 19, 2024 · 0 comments · Fixed by #1473
Assignees
@parthosa
Labels
bug Something isn't working

Comments

@parthosa
Copy link
Collaborator

parthosa commented Dec 19, 2024 •
edited
Loading

After the changes in #1462, the --help output for the CLI command should reflect that the platform parameter is mandatory.

Current Behavior

Running the command spark_rapids qualification -- --help incorrectly shows the platform argument as optional:

 -p, --platform=PLATFORM
        Type: Optional[str]
        Default: None
        defines one of the following "onprem", "emr", "dataproc", "dataproc-gke", "databricks-aws", and "databricks-azure".
@parthosa parthosa added the bug Something isn't working label Dec 19, 2024
@parthosa parthosa self-assigned this Dec 19, 2024
@parthosa parthosa mentioned this issue Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthosa parthosa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Follow Up: Make '--platform' argument mandatory in CLI parthosa/spark-rapids-tools
1 participant
@parthosa