Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Reduce the noise in tools logs #1416

Open
1 of 3 tasks
Tracked by #1038
amahussein opened this issue Nov 8, 2024 · 0 comments
Open
1 of 3 tasks
Tracked by #1038

[FEA] Reduce the noise in tools logs #1416

amahussein opened this issue Nov 8, 2024 · 0 comments
Assignees
@parthosa
Labels
core_tools Scope the core module (scala) feature request New feature or request good first issue Good for newcomers usability track issues related to the Tools's user experience user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@amahussein
Copy link
Collaborator

amahussein commented Nov 8, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Tools core logs the path each time it generates a new output file.
This makes the logs very noisy and hard to read; especially with processing hundreds/thousands of eventlogs at a time.
In addition, the QualX module will show warning everytime a file is missing from the output. This renders logging the path by the core useless

Describe the solution you'd like

We should only log once on the directory of the output path. If necessary, log all the file names in one message rather than building one file at a time.

Tasks
Preview Give feedback
  1. Reduce the log noise caused by core report summary #1426
    core_tools
    amahussein
@amahussein amahussein added ? - Needs Triage core_tools Scope the core module (scala) feature request New feature or request good first issue Good for newcomers usability track issues related to the Tools's user experience labels Nov 8, 2024
@amahussein amahussein changed the title [FEA] REduce the noise in core tools logs [FEA] Reduce the noise in core tools logs Nov 12, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Nov 15, 2024
@amahussein
Reduce the log noise caused by core report summary
26f0ab4 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Contributes to NVIDIA#1416

This change set the log level of ToolTextFileWriter to debug and
summarize the logging into a single message to show the final directory
This was referenced Nov 15, 2024
Merged
Open
@amahussein amahussein changed the title [FEA] Reduce the noise in core tools logs [FEA] Reduce the noise in tools logs Nov 15, 2024
@amahussein amahussein added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Nov 15, 2024
amahussein added a commit that referenced this issue Nov 19, 2024
@amahussein
Reduce the log noise caused by core report summary (#1426)
9cba927 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Contributes to #1416

This change set the log level of ToolTextFileWriter to debug and
summarize the logging into a single message to show the final directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthosa parthosa

Labels
core_tools Scope the core module (scala) feature request New feature or request good first issue Good for newcomers usability track issues related to the Tools's user experience user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthosa @amahussein