Skip to content

Commit

Permalink
Reduce the log noise caused by core report summary (#1426)
Browse files Browse the repository at this point in the history
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Contributes to #1416

This change set the log level of ToolTextFileWriter to debug and
summarize the logging into a single message to show the final directory
  • Loading branch information
amahussein authored Nov 19, 2024
1 parent 6af4bdb commit 9cba927
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class ToolTextFileWriter(
// No need to close the outputStream.
// Java should handle nested streams automatically.
utf8Writer.foreach { writer =>
logInfo(s"$finalLocationText output location: $textOutputLoc")
logDebug(s"$finalLocationText output location: $textOutputLoc")
writer.flush()
writer.close()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ class Profiler(hadoopConf: Configuration, appArgs: ProfileArgs, enablePB: Boolea
progressBar.foreach(_.finishAll())

// Write status reports for all event logs to a CSV file
logOutputPath()
val reportResults = generateStatusResults(appStatusReporter.asScala.values.toSeq)
ProfileOutputWriter.writeCSVTable("Profiling Status", reportResults, outputDir)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,6 @@ class Qualification(outputPath: String, numRows: Int, hadoopConf: Configuration,
}
}

/**
* The outputPath of the current instance of the provider
*/
def getReportOutputPath: String = {
s"$outputDir/rapids_4_spark_qualification_output"
}

/**
* Generates a qualification report based on the provided summary information.
*/
Expand All @@ -263,6 +256,7 @@ class Qualification(outputPath: String, numRows: Int, hadoopConf: Configuration,
qWriter.writeStageReport(allAppsSum, order)
qWriter.writeUnsupportedOpsSummaryCSVReport(allAppsSum)
val appStatusResult = generateStatusResults(appStatusReporter.asScala.values.toSeq)
logOutputPath()
qWriter.writeStatusReport(appStatusResult, order)
if (mlOpsEnabled) {
if (allAppsSum.exists(x => x.mlFunctions.nonEmpty)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ trait RuntimeReporter extends Logging {
def generateRuntimeReport(hadoopConf: Option[Configuration] = None): Unit = {
RuntimeUtil.generateReport(outputDir, hadoopConf)
}
def logOutputPath(): Unit = {
logInfo(s"Tools output directory: $outputDir")
}

/**
* Updates the status of "SUCCESS" applications to "SKIPPED" if newer attempts with
Expand Down

0 comments on commit 9cba927

Please sign in to comment.