Skip to content

Commit

Permalink
address code review
Browse files Browse the repository at this point in the history
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
  • Loading branch information
amahussein committed Dec 13, 2023
1 parent 98c825d commit 6952d6e
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,14 @@ object ToolUtils extends Logging {
val targetEx = i.getTargetException
if (targetEx != null) {
targetEx match {
case k: com.fasterxml.jackson.core.io.JsonEOFException =>
case j: com.fasterxml.jackson.core.io.JsonEOFException =>
// Spark3.41+ embeds JsonEOFException in the InvocationTargetException
// We need to show a warning message instead of failing the entire app.
logWarning(s"Incomplete eventlog, ${k.getMessage}")
case j: com.fasterxml.jackson.core.JsonParseException =>
logWarning(s"Incomplete eventlog, ${j.getMessage}")
case k: com.fasterxml.jackson.core.JsonParseException =>
// this is a parser error thrown by spark-3.4+ which indicates the log is
// malformed
throw j
throw k
case z: ClassNotFoundException if z.getMessage != null =>
logWarning(s"ClassNotFoundException while parsing an event: ${z.getMessage}")
case t: Throwable =>
Expand Down

0 comments on commit 6952d6e

Please sign in to comment.