Skip to content

Commit

Permalink
Remove pylint disable rule in CSPs
Browse files Browse the repository at this point in the history
Signed-off-by: Partho Sarthi <[email protected]>
  • Loading branch information
parthosa committed Dec 17, 2024
1 parent 9b8111a commit 1ea8147
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from spark_rapids_pytools.pricing.price_provider import SavingsEstimator


# pylint: disable=abstract-method
@dataclass
class DBAWSPlatform(EMRPlatform):
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
from spark_rapids_pytools.pricing.price_provider import SavingsEstimator


# pylint: disable=abstract-method
@dataclass
class DBAzurePlatform(PlatformBase):
"""
Expand Down Expand Up @@ -89,6 +88,9 @@ def create_saving_estimator(self,
def create_local_submission_job(self, job_prop, ctxt) -> Any:
return DBAzureLocalRapidsJob(prop_container=job_prop, exec_ctxt=ctxt)

def create_distributed_submission_job(self, job_prop, ctxt) -> Any:
pass

def validate_job_submission_args(self, submission_args: dict) -> dict:
pass

Expand Down
4 changes: 3 additions & 1 deletion user_tools/src/spark_rapids_pytools/cloud_api/dataproc.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from spark_rapids_pytools.pricing.price_provider import SavingsEstimator


# pylint: disable=abstract-method
@dataclass
class DataprocPlatform(PlatformBase):
"""
Expand Down Expand Up @@ -131,6 +130,9 @@ def create_saving_estimator(self,
def create_local_submission_job(self, job_prop, ctxt) -> Any:
return DataprocLocalRapidsJob(prop_container=job_prop, exec_ctxt=ctxt)

def create_distributed_submission_job(self, job_prop, ctxt) -> Any:
pass

def validate_job_submission_args(self, submission_args: dict) -> dict:
pass

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
from spark_rapids_tools import CspEnv


# pylint: disable=abstract-method
@dataclass
class DataprocGkePlatform(DataprocPlatform):
"""
Expand Down Expand Up @@ -93,6 +92,9 @@ def create_saving_estimator(self,
def create_local_submission_job(self, job_prop, ctxt) -> Any:
return DataprocGkeLocalRapidsJob(prop_container=job_prop, exec_ctxt=ctxt)

def create_distributed_submission_job(self, job_prop, ctxt) -> Any:
pass


@dataclass
class DataprocGkeCMDDriver(DataprocCMDDriver):
Expand Down
4 changes: 3 additions & 1 deletion user_tools/src/spark_rapids_pytools/cloud_api/emr.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from spark_rapids_pytools.pricing.price_provider import SavingsEstimator


# pylint: disable=abstract-method
@dataclass
class EMRPlatform(PlatformBase):
"""
Expand Down Expand Up @@ -116,6 +115,9 @@ def create_saving_estimator(self,
def create_local_submission_job(self, job_prop, ctxt) -> Any:
return EmrLocalRapidsJob(prop_container=job_prop, exec_ctxt=ctxt)

def create_distributed_submission_job(self, job_prop, ctxt) -> Any:
pass

def generate_cluster_configuration(self, render_args: dict):
image_version = self.configs.get_value_silent('clusterInference', 'defaultImage')
render_args['IMAGE'] = f'"{image_version}"'
Expand Down

0 comments on commit 1ea8147

Please sign in to comment.