-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch rmm::get_current_device_resource
to use references via rmm::get_current_device_resource_ref
#2372
Switch rmm::get_current_device_resource
to use references via rmm::get_current_device_resource_ref
#2372
Conversation
Signed-off-by: Mike Wilson <[email protected]>
rmm::get_current_device_resource
to use references via rmm::get_current_device_resource_ref
Signed-off-by: Mike Wilson <[email protected]>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hyperbolic2346 !
@hyperbolic2346 @abellina you guys are getting a step ahead of me. Probably would have been nice to wait on rapidsai/cudf#16679 so you can use the cudf wrappers. That way if we need to change anything we can do it in one place in cudf. |
@harrism sorry about that. I will include that wrapper once it is merged. |
Sorry @hyperbolic2346 and @harrism I didn't realize rapidsai/cudf#16679 was in the works. |
BTW, I believe that this PR introduces a bug until rapidsai/rmm/#1661 is merged. That PR makes |
…ia `rmm::get_current_device_resource_ref` (NVIDIA#2372)" This reverts commit ad271f0.
Thanks @harrism we'll revert this for now until the RMM pr is merged. |
OK, rapidsai/rmm#1661 is now merged. |
This changes the use of
rmm::get_current_device_resource
tormm::get_current_device_resource_ref
to match up with the RMM incoming deprecation. I don't know when the original methods will be deprecated, but the new methods are available now, so it seemed a good idea to switch over.closes #2358