Update for changes to Arrow linkage in libcudf #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Build |
jlowe
reviewed
Aug 27, 2024
There was a problem hiding this comment.
This PR will need to explicitly update the thirdparty/cudf submodule to a version that contains rapidsai/cudf#16640, e.g.: latest branch-24.10, so it can test with those changes. We periodically update the submodule to follow cudf changes, but those updates will only automatically occur if it builds and tests pass. Since it won't build as-is without these changes, we'll need this PR to pull in the cudf changes.
|
Build |
|
Thanks for confirming Jason. I've updated the branch and attempted to trigger a build although I suspect I won't have the power to do so. |
jlowe
approved these changes
Aug 27, 2024
|
build |
jlowe
reviewed
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rapidsai/cudf#16640, the libcudf library no longer links to arrow. While that dependency has been removed, the Java native code has not been updated to avoid arrow and still needs it for interop with arrow buffers (cudf now uses nanoarrow). While that may be removed in the future, for now the spark-rapids-jni needs to have its build updated to support the new location of arrow libraries and headers since they are now within the libcudfjni build instead of the libcudf build.
This PR depends on rapidsai/cudf#16640, but will be required for spark-rapids-jni to build once that cudf PR is merged.