Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for CI/CD compatibility #446

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Fixes for CI/CD compatibility #446

merged 7 commits into from
Oct 18, 2024

Conversation

rishic3
Copy link
Contributor

@rishic3 rishic3 commented Oct 15, 2024 •
edited
Loading

Changes: CI/CD

  1. Avoid hardcoding RAPIDS Jar version for CI/CD. Instead, let pipeline download and store jar path in $RAPIDS_JAR environment variable, as specified in this PR. Allows us to pull the appropriate plugin version from Spark-RAPIDS.
  2. Use unique (timestamped) paths for the TensorRT timing cache, in response to this bug, so that cached files can be properly cleaned up.

Bug Fixes:

  • Deleted duplicate image_classification notebook in Tensorflow

@rishic3 rishic3 marked this pull request as ready for review October 17, 2024 15:58
jlowe
jlowe previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me.

eordentlich
eordentlich previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

YanxuanLiu
YanxuanLiu previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@YanxuanLiu YanxuanLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PCA part. We can remove the DL changes, since we discussed with @rishic3 on Slack that we will run dl notebook pipeline in container, we do not need to care about the cache dirs.

@rishic3 rishic3 dismissed stale reviews from YanxuanLiu and eordentlich via da16be6 October 18, 2024 18:16
@rishic3
Copy link
Contributor Author

rishic3 commented Oct 18, 2024

Markdown link checker is unhappy with tensorflow links for an unknown reason. Switching to use links to the Github source instead for now.

eordentlich
eordentlich approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eordentlich eordentlich merged commit 4940bf8 into NVIDIA:branch-24.10 Oct 18, 2024
2 checks passed
@rishic3 rishic3 deleted the cicd branch October 18, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eordentlich eordentlich eordentlich approved these changes

@YanxuanLiu YanxuanLiu YanxuanLiu left review comments

@jlowe jlowe jlowe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishic3 @jlowe @eordentlich @YanxuanLiu