-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto merge PRs to branch-24.06 from branch-24.04 [skip ci] #369
Conversation
Signed-off-by: Tim Liu <[email protected]>
Signed-off-by: Tim Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is marked skip ci but has a bunch of changes we would want to run through CI. I suspect there's much more that was pushed to this PR than what was intended.
@@ -21,7 +21,7 @@ | |||
<groupId>com.nvidia</groupId> | |||
<artifactId>PCAExample</artifactId> | |||
<packaging>jar</packaging> | |||
<version>24.04.0-SNAPSHOT</version> | |||
<version>24.06.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to 24.06 on the 24.04 branch?
@@ -16,7 +16,7 @@ | |||
|
|||
cmake_minimum_required(VERSION 3.23.1 FATAL_ERROR) | |||
|
|||
file(DOWNLOAD https://raw.githubusercontent.com/rapidsai/rapids-cmake/branch-24.04/RAPIDS.cmake | |||
file(DOWNLOAD https://raw.githubusercontent.com/rapidsai/rapids-cmake/branch-24.06/RAPIDS.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downloading 24.06 on 24.04 branch?
Sorry I pushed the wrong branch, close this PR @jlowe Thanks a lot for correcting it. |
As the title