Support scala 2.13 for xgboost samples #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NvTimLiu could you help to check it? |
Signed-off-by: Bobby Wang <[email protected]>
jlowe
reviewed
Jan 17, 2024
| @@ -1,7 +1,7 @@ | |||
| <assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0" | |||
There was a problem hiding this comment.
ASLv2 and NVIDIA copyrights missing from this file.
There was a problem hiding this comment.
Thx for the info, Don.e
jlowe
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds scala version for the artifactId to distinguish the scala 2.12 and scala 2.13.
To compile xgboost samples against scala 2.13, you can use below command