-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine UDF guide doc #320
refine UDF guide doc #320
Conversation
Signed-off-by: liyuan <[email protected]>
Signed-off-by: liyuan <[email protected]>
Co-authored-by: Liangcai Li <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
One suggestion - try to keep lines to 100 characters for ease of reading the source. |
Signed-off-by: liyuan <[email protected]>
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Sameer that we should strive to wrap the test around column 100. Some of these suggestions will require reformatting of the paragraph if taken verbatim.
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Signed-off-by: liyuan <[email protected]>
Signed-off-by: liyuan <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
Signed-off-by: liyuan <[email protected]>
Signed-off-by: liyuan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVIDIA/spark-rapids#9362 recently removed the getting started documentation, as it is replaced by the docs at https://docs.nvidia.com/spark-rapids/user-guide/latest/index.html instead. All of the links here need to point to the new location, otherwise they will be broken links when 23.10 releases.
Signed-off-by: liyuan <[email protected]>
sorry for the late response, updated the links to the new urls. |
Signed-off-by: liyuan <[email protected]>
Signed-off-by: liyuan <[email protected]>
Signed-off-by: liyuan <[email protected]>
This is to refine getting started on UDF doc.