Return golang errors instead of nvml.Return values #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
|
Your two example's in the description are the same .. I think you wanted one of them to check euqility instead of using That said -- what will happen if someone does do |
klueska
reviewed
Jul 10, 2024
Comment on lines
+56
to
+63
| current, pending, err := device.GetMigMode() | ||
| if errors.Is(err, nvml.ERROR_NOT_SUPPORTED) { | ||
| fmt.Printf("MIG is not supported for device %v\n", i) | ||
|
|
||
| } else if err != nil { | ||
| log.Fatalf("Error getting MIG mode for device at index %d: %v", i, err) | ||
| } | ||
| fmt.Printf("MIG mode for device %v: current=%v pending=%v\n", i, current, pending) |
There was a problem hiding this comment.
Can we change this to:
current, pending, err := device.GetMigMode()
if err == nil {
fmt.Printf("MIG mode for device %v: current=%v pending=%v\n", i, current, pending)
continue
}
if errors.Is(err, nvml.ERROR_NOT_SUPPORTED) {
fmt.Printf("MIG is not supported for device %v\n", i)
continue
}
log.Fatalf("Error getting MIG mode for device at index %d: %v", i, err)
klueska
reviewed
Jul 10, 2024
There was a problem hiding this comment.
None of the changes in this file look intentional...
klueska
reviewed
Jul 10, 2024
Comment on lines
22
to
24
| func (l *library) ErrorString(r Return) string { | ||
| return r.Error() | ||
| return r.String() | ||
| } |
There was a problem hiding this comment.
How does an end-user ever get ahold of a Return value to pass it to this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move from using
nvml.Returnvalues to using native Golangerrorvalues, making code more idiomatic.Note that this requires that
error.Isis used instead of checking for equality in the returned value.For example:
would become: