Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cuco::arrow_filter_policy to accept a custom implementation of xxhash_64 #642

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Allow cuco::arrow_filter_policy to accept a custom implementation of xxhash_64 #642

merged 10 commits into from
Nov 21, 2024

Conversation

mhaseeb123
Copy link
Contributor

@mhaseeb123 mhaseeb123 commented Nov 19, 2024 •
edited
Loading

This PR allows cuco::arrow_filter_policy to accept a custom implementation of xxhash_64 hasher or use cuco::xxhash_64 if nothing provided. Related to rapidsai/cudf#17164 and rapidsai/cudf#17393

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

PointKernel
PointKernel reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's use cuda::std:: utilities when possible for all host-device functions.

include/cuco/detail/hash_functions/xxhash.cuh Outdated Show resolved Hide resolved
include/cuco/detail/hash_functions/xxhash.cuh Outdated Show resolved Hide resolved
include/cuco/detail/hash_functions/xxhash.cuh Outdated Show resolved Hide resolved
@mhaseeb123 mhaseeb123 changed the title Enable span like keys for xxhash_64 hasher for cuco::arrow_filter_policy Enable span like keys for xxhash hashers for cuco::arrow_filter_policy Nov 20, 2024
@mhaseeb123 mhaseeb123 marked this pull request as ready for review November 20, 2024 01:35
@mhaseeb123 mhaseeb123 marked this pull request as draft November 20, 2024 02:29
@mhaseeb123
Copy link
Contributor Author

mhaseeb123 commented Nov 20, 2024 •
edited
Loading

Converting to draft to add a couple of bitwise tests for string types with Arrow's implementation. Please feel free to look at the code already pushed here as any addition will only be tests.

@mhaseeb123 mhaseeb123 changed the title Enable span like keys for xxhash hashers for cuco::arrow_filter_policy Allow arrow_filter_policy to accept a custom implementation of xxhash_64. Nov 21, 2024
@mhaseeb123 mhaseeb123 marked this pull request as ready for review November 21, 2024 06:42
@mhaseeb123 mhaseeb123 changed the title Allow arrow_filter_policy to accept a custom implementation of xxhash_64. Allow cuco::arrow_filter_policy to accept a custom implementation of xxhash_64. Nov 21, 2024
@PointKernel
Copy link
Member

/ok to test

@PointKernel
Copy link
Member

/ok to test

@PointKernel PointKernel changed the title Allow cuco::arrow_filter_policy to accept a custom implementation of xxhash_64. Allow cuco::arrow_filter_policy to accept a custom implementation of xxhash_64 Nov 21, 2024
@sleeepyjack sleeepyjack merged commit 1bb0ae6 into NVIDIA:dev Nov 21, 2024
18 checks passed
@mhaseeb123 mhaseeb123 deleted the fea/support-for-span-like-arrow-filter-policy branch November 21, 2024 20:14
@mhaseeb123 mhaseeb123 mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@sleeepyjack sleeepyjack sleeepyjack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhaseeb123 @PointKernel @sleeepyjack