Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update port strategy to random assignment #301

Merged
merged 16 commits into from
Dec 19, 2024

Conversation

gwarmstrong
Copy link
Collaborator

This introduces a random port assignment strategy to reduce port collisions when running jobs in non-exclusive mode.

@gwarmstrong gwarmstrong requested a review from Kipok December 19, 2024 01:38
Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Did you run gpu tests (rm/qwen) with this locally?

Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove exclusive=True if all works well

@gwarmstrong
Copy link
Collaborator Author

Looks great, thanks! Did you run gpu tests (rm/qwen) with this locally?

Yeah those tests look good locally

Let's remove exclusive=True if all works well

I'll test it on the cluster tomorrow with the exclusive flag dropped.

@gwarmstrong gwarmstrong merged commit e2a934e into main Dec 19, 2024
4 checks passed
@gwarmstrong gwarmstrong deleted the georgea/update-port-strategy branch December 19, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants