Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple improvements #299

Merged
merged 25 commits into from
Dec 18, 2024
Merged

Multiple improvements #299

merged 25 commits into from
Dec 18, 2024

Conversation

Kipok
Copy link
Collaborator

@Kipok Kipok commented Dec 18, 2024

  1. Handle decontamination by passing the "index" file with all problems only. This avoids a costly step of assigning labels to each solution, which can be many per problem as well as makes it easier to switch decontamination models/test sets.
  2. Add require_num_files parameter to fill answer script to make it possible to use it in large pipelines and automatically fail if some of the random seeds from previous step are completely missing
  3. Add more logging to fill answer script to be able to gain more visibility into what has changed after it ran
  4. Fix some edge cases handling in llm judge script
  5. Add reuse_code_exp parameter that allows to avoid uploading code to cluster and reuse it from another experiment. Requires latest nemo-run
  6. Add mail_user/type to cluster configs to make it possible to get emails on failure
  7. Some optimizations on the sft prepare default parameters + a couple of new filters
  8. Make it possible to pass exclusive flag to run_cmd as it's often necessary when using cpu jobs (e.g. with prepare sft data on largest datasets we need as much memory/cpu as we can get)
  9. Add WANDB_API_KEY as a default env var to pick up

Kipok added 25 commits December 14, 2024 10:18
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
@Kipok Kipok merged commit 702edb2 into main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant