Port passthrough for generation servers #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gwarmstrong the gpu ci is currently not functional unfortunately |
Okay I'll do some more extensive testing locally then |
…NVIDIA/NeMo-Skills into georgea/passthrough-port-configurations
gwarmstrong
changed the title
|
Please update start_server.py as well |
Kipok
reviewed
Dec 17, 2024
gwarmstrong
commented
Dec 17, 2024
added in 87bf1fa |
Kipok
reviewed
Dec 17, 2024
Co-authored-by: Igor Gitman <[email protected]>
Kipok
reviewed
Dec 17, 2024
Kipok
reviewed
Dec 17, 2024
gwarmstrong
commented
Dec 17, 2024
Co-authored-by: Igor Gitman <[email protected]>
Kipok
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies server startups to take a passed port instead of hard-coded values. The
get_free_portmethod will be updated in a future PR to change port configuration strategies from static to random to avoid collisions.