Apply suggestions from code review

Co-authored-by: Igor Gitman <[email protected]>
NVIDIA · Dec 17, 2024 · dc1c3b2 · dc1c3b2
1 parent 145214e
commit dc1c3b2
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/nemo_skills/pipeline/utils.py b/nemo_skills/pipeline/utils.py
@@ -189,7 +189,7 @@ def get_server_command(
     num_nodes: int,
     model_path: str,
     cluster_config: dict,
-    server_port: int = 5000,
+    server_port: int,
     server_args: str = "",
 ):
     num_tasks = num_gpus
@@ -776,8 +776,7 @@ def add_task(
     executors = []
     # assuming server always has the largest resources request, so it needs to go first
     if server_config is not None:
-        server_port = server_config["server_port"]
-        server_cmd, num_server_tasks = get_server_command(**server_config, server_port=server_port, cluster_config=cluster_config)
+        server_cmd, num_server_tasks = get_server_command(**server_config, cluster_config=cluster_config)
         if 'container' not in server_config:
             server_container = cluster_config["containers"][server_config['server_type']]
         server_executor = get_executor(