add workflow for syncing #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerald Shen <[email protected]>
Signed-off-by: Gerald Shen <[email protected]>
odelalleau
reviewed
Jan 9, 2024
Signed-off-by: Gerald Shen <[email protected]>
Co-authored-by: Olivier Delalleau <[email protected]>
thanks! I think it should be okay, I got it from github market place. It should work well |
gshennvm
commented
Jan 9, 2024
| @@ -318,7 +318,7 @@ def on_load_checkpoint(self, checkpoint) -> None: | |||
| """ | |||
| # mcore uses distributed checkpointing | |||
| if "state_dict" in checkpoint and checkpoint["state_dict"]: | |||
| for index, module in enumerate(self.get_gpt_module_list()): | |||
There was a problem hiding this comment.
whoops: will remove once everything else looks good to you
gshennvm
commented
Jan 9, 2024
| @@ -38,7 +38,7 @@ def set_sync_funcs(ptl_model, forward_only): | |||
| param_sync_func = ptl_model.sync_overlap_parameters | |||
|
|
|||
| # pipeline schedules will get these from ptl_model.model.config | |||
| for module in ptl_model.get_gpt_module_list(): | |||
There was a problem hiding this comment.
whoops again: will remove once everything else looks good to you
odelalleau
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
dev should be branch that tracks main but has all the commits whenever nemo changes things. We will sync this branch with main every release