Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rlhf model link #63

Closed
wants to merge 6 commits into from
Closed

add rlhf model link #63

wants to merge 6 commits into from

Conversation

HeyyyyyyG
Copy link
Collaborator

What does this PR do ?

Add NV-Llama2-70B-RLHF model link

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: jiaqiz <[email protected]>
@HeyyyyyyG HeyyyyyyG requested a review from gshennvm December 18, 2023 23:36
HeyyyyyyG and others added 5 commits December 18, 2023 19:46
Signed-off-by: jiaqiz <[email protected]>
Signed-off-by: Jiaqi Zeng <[email protected]>
…ligner into jiaqiz/add_rlhf_model_link

Signed-off-by: Jiaqi Zeng <[email protected]>
* add timer class

Signed-off-by: Gerald Shen <[email protected]>

* fixup! add timer class

Signed-off-by: Gerald Shen <[email protected]>

* change check progress function

Signed-off-by: Gerald Shen <[email protected]>

* add timer to rm

Signed-off-by: Gerald Shen <[email protected]>

* add timer to supervised trainer

Signed-off-by: Gerald Shen <[email protected]>

* Update examples/nlp/gpt/train_reward_model.py

Co-authored-by: Olivier Delalleau <[email protected]>
Signed-off-by: Gerald Shen <[email protected]>

* Update nemo_aligner/utils/distributed.py

Co-authored-by: Olivier Delalleau <[email protected]>
Signed-off-by: Gerald Shen <[email protected]>

* add logging when finished

Signed-off-by: Gerald Shen <[email protected]>

* Update nemo_aligner/utils/distributed.py

Co-authored-by: Olivier Delalleau <[email protected]>
Signed-off-by: Gerald Shen <[email protected]>

* add timer into sft examples

Signed-off-by: Gerald Shen <[email protected]>

* add timer onto dpo

Signed-off-by: Gerald Shen <[email protected]>

* add check progress onto PPO

Signed-off-by: Gerald Shen <[email protected]>

* add timer onto ppo

Signed-off-by: Gerald Shen <[email protected]>

* update changelog

Signed-off-by: Gerald Shen <[email protected]>

* update changelog

Signed-off-by: Gerald Shen <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Olivier Delalleau <[email protected]>

---------

Signed-off-by: Gerald Shen <[email protected]>
Co-authored-by: Olivier Delalleau <[email protected]>
Co-authored-by: trias702 <[email protected]>
Signed-off-by: jiaqiz <[email protected]>
Signed-off-by: Jiaqi Zeng <[email protected]>
…ligner into jiaqiz/add_rlhf_model_link

Signed-off-by: Jiaqi Zeng <[email protected]>
@HeyyyyyyG HeyyyyyyG closed this Dec 19, 2023
@HeyyyyyyG HeyyyyyyG deleted the jiaqiz/add_rlhf_model_link branch December 19, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants