Remove batching from PyTriton endpoints for critic train / save #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshennvm
reviewed
Nov 11, 2023
|
ah, can you sign this commit? |
The batched version causes problems with PyTriton 0.4 because the output's batch shape does not match the input's. Signed-off-by: Olivier Delalleau <[email protected]>
odelalleau
force-pushed
the
od/pytriton-unbatching
branch
from
d56c6d9 to
33d3637
Compare
Ah sorry, forgot about this new requirement. Rebased & signed in 33d3637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The batched version causes problems with PyTriton 0.4 because the output's batch shape does not match the input's.
Changelog
Not adding to changelog since this shouldn't be a user-facing change, we'll just update dependencies / containers
Before your PR is "Ready for review"
Pre checks:
Additional Information
Not tested yet with github code