Cherry pick docs: add a link to NeMo's known issues page (402) into r0.5.0
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerald Shen <[email protected]>
Signed-off-by: Gerald Shen <[email protected]>
Signed-off-by: Gerald Shen <[email protected]>
Signed-off-by: Gerald Shen <[email protected]>
* Revert "add pref" This reverts commit 7dddeef. Signed-off-by: Terry Kong <[email protected]> * Revert "update docs" This reverts commit 3d0a650. Signed-off-by: Terry Kong <[email protected]> * revert steerlm2 docs Signed-off-by: Terry Kong <[email protected]> * revert rpo/ipo docs Signed-off-by: Terry Kong <[email protected]> * revert trtllm doc change on frontpage Signed-off-by: Terry Kong <[email protected]> * Update CHANGELOG.md to 0.4.0 Signed-off-by: Terry Kong <[email protected]> * remove aview(-1) Signed-off-by: Terry Kong <[email protected]> * Addressing #260 (comment) Signed-off-by: Terry Kong <[email protected]> * apply next batch of suggestions Signed-off-by: Terry Kong <[email protected]> * applied suggestions in #260 (comment) Signed-off-by: Terry Kong <[email protected]> * appliying suggestions in #260 (comment) Signed-off-by: Terry Kong <[email protected]> * Update dpo.rst Provided copyedits on file. Signed-off-by: Terry Kong <[email protected]> * Update index.rst Added copyedits to the file. Signed-off-by: Terry Kong <[email protected]> * Update rlhf.rst Copyedited the file. Signed-off-by: Terry Kong <[email protected]> * one space Signed-off-by: Terry Kong <[email protected]> * revert steerlm2 deletion Signed-off-by: Terry Kong <[email protected]> * restore rpo changes Signed-off-by: Terry Kong <[email protected]> * restore missing regression comment Signed-off-by: Terry Kong <[email protected]> * restore trtllm changeswq Signed-off-by: Terry Kong <[email protected]> * restore sterrlm2 in index.rst Signed-off-by: Terry Kong <[email protected]> * restore lost spacing Signed-off-by: Terry Kong <[email protected]> --------- Signed-off-by: Terry Kong <[email protected]> Co-authored-by: jgerh <[email protected]>
Which was introduced in this mcore commit: NVIDIA/Megatron-LM@32002bb Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
…f transformer_config.num_moe_experts NVIDIA/NeMo#9035
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ible by parallel state (#333) Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: ashors1 <[email protected]> Co-authored-by: Terry Kong <[email protected]> Signed-off-by: Terry Kong <[email protected]>
terrykong
changed the title
docs: fix code block rendering (369) into r0.5.0docs: add a link to NeMo's known issues page (402) into r0.5.0
ko3n1g
previously approved these changes
Nov 15, 2024
github-actions
bot
added
the
documentation
|
It looks like this cherry-pick picked up more than just my changes. Could we verify that all of the changes are intentional? |
|
closing this since at this point it's easier to just publish the state on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Checklist when contributing a new algorithm
max_steps=-1andvalidation?Additional Information