Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geshen/fix package info #37

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Geshen/fix package info #37

merged 1 commit into from
Dec 4, 2023

Conversation

gshennvm
Copy link
Collaborator

@gshennvm gshennvm commented Dec 4, 2023

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Gerald Shen <[email protected]>
@gshennvm gshennvm force-pushed the geshen/fix_package_info branch from 1b35505 to 24cf9cd Compare December 4, 2023 02:12
@gshennvm gshennvm merged commit ef45090 into main Dec 4, 2023
1 of 2 checks passed
@gshennvm gshennvm deleted the geshen/fix_package_info branch December 4, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant