Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Forward mbs #14

Closed
wants to merge 10 commits into from
Closed

DRAFT: Forward mbs #14

wants to merge 10 commits into from

Conversation

gshennvm
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

gshennvm and others added 4 commits November 8, 2023 20:24
@gshennvm
initial commit
6dc5960
@gshennvm
save at end of training(#7)
5300d23 
Signed-off-by: Gerald Shen <[email protected]>
@gshennvm
Geshen/fix name and json ppo (#10)
f9e3686 
* change default config name

Signed-off-by: Gerald Shen <[email protected]>

* pick from json fix

Signed-off-by: Gerald Shen <[email protected]>

---------

Signed-off-by: Gerald Shen <[email protected]>
@trias702
DPO (#11)
b9ac1f6 
* Initial commit of DPO

Signed-off-by: Daniel Egert <[email protected]>

* Polish changes suggested

Signed-off-by: Daniel Egert <[email protected]>

* More polishing changes requested

Signed-off-by: Daniel Egert <[email protected]>

* More polish and formatting changes

Signed-off-by: Daniel Egert <[email protected]>

* Removed configure_batch_size logic from dpo model

Signed-off-by: Daniel Egert <[email protected]>

---------

Signed-off-by: Daniel Egert <[email protected]>
@github-actions github-actions bot added the Utils label Nov 18, 2023
@gshennvm
Copy link
Collaborator Author

depends on GH-15

gshennvm and others added 6 commits November 18, 2023 21:48
@gshennvm gshennvm closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gshennvm @trias702 @odelalleau