Skip to content

Commit

Permalink
Fix instructions to sign commits
Browse files Browse the repository at this point in the history
This is so that both the "Signed-off-by" message *and* the proper GPG
signature are used.

Signed-off-by: Olivier Delalleau <[email protected]>
  • Loading branch information
odelalleau committed Dec 20, 2023
1 parent 17eb571 commit 6ab160a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Thanks for the interest in contributing to NeMo-Aligner. We do all of NeMo-Align

1) Make sure your PR does one thing. Have a clear answer to "What does this PR do?".
2) Read General Principles and style guide below
3) Make sure you sign your commits. E.g. use ``git commit -s`` when before your commit
3) Make sure you sign your commits. E.g. use ``git commit -sS`` when committing.
4) Make sure all unittests finish successfully before sending PR ``pytest`` or (if your dev box does not have GPU) ``pytest --cpu`` from the root folder
5) Send your PR and request a review

Expand Down Expand Up @@ -54,4 +54,4 @@ We use ``black`` as our style guide. To fix your format run `pip install pre-com
# Algorithms
Algorithms is a grouping of trainers that coordinate training. Before contributing see if you can use an existing algorithm implementation for your use case.

Thank you for contributing to NeMo-Aligner!
Thank you for contributing to NeMo-Aligner!

0 comments on commit 6ab160a

Please sign in to comment.