Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger hierarchy #3081

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Logger hierarchy #3081

wants to merge 4 commits into from
+285 −176

Conversation

SYangster
Copy link
Collaborator

  • Convert loggers to match hierarchical module structure
  • Add BaseFormatter to shorten logger names to suffix, base for future formatters
  • Add print_logger_hierarchy utility function

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster marked this pull request as ready for review November 27, 2024 18:57
YuanTingHsieh
YuanTingHsieh reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obj logger get_logger is good,
I think it will be good if we have get_cls_logger, or get_module_logger or equivalent stuff

nvflare/apis/utils/fl_context_utils.py Outdated Show resolved Hide resolved
nvflare/apis/fl_context.py Outdated Show resolved Hide resolved
nvflare/apis/utils/reliable_message.py Outdated Show resolved Hide resolved
nvflare/app_common/aggregators/dxo_aggregator.py Outdated Show resolved Hide resolved
nvflare/app_common/executors/task_script_runner.py Outdated Show resolved Hide resolved
nvflare/app_opt/pt/utils.py Outdated Show resolved Hide resolved
nvflare/fuel/f3/mpm.py Outdated Show resolved Hide resolved
@SYangster SYangster force-pushed the logging_hierarchy branch 4 times, most recently from e02ba6f to 2f24362 Compare December 3, 2024 17:22
@SYangster SYangster mentioned this pull request Dec 3, 2024
Draft
6 tasks
YuanTingHsieh
YuanTingHsieh reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

nvflare/app_opt/pt/utils.py Show resolved Hide resolved
nvflare/fuel/utils/log_utils.py Show resolved Hide resolved
nvflare/fuel/f3/mpm.py Show resolved Hide resolved
nvflare/app_common/aggregators/dxo_aggregator.py Show resolved Hide resolved
YuanTingHsieh
YuanTingHsieh previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh left review comments

@yhwen yhwen Awaiting requested review from yhwen

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

@nvidianz nvidianz Awaiting requested review from nvidianz

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @chesterxgchen @YuanTingHsieh