Add storage capability for client logs and allow for use with LogSender and LogReceiver #3077
+197
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
|
/build |
YuanTingHsieh
requested review from
yhwen,
SYangster,
yanchengnv and
nvidianz
|
Refactored to make it more configurable |
|
/build |
Comment on lines
+115
to
+117
| FileStreamer.register_stream_processing( | ||
| fl_ctx, channel=channel, topic=LOG_STREAM_EVENT_TYPE, stream_done_cb=self.process_log | ||
| ) |
There was a problem hiding this comment.
We could also say this LogSender and LogReceiver is always using the same channel but for different types of logs they send/receive they use different "topic"?
Now is the same "topic" but different "channel" I guess we just need to explain what we prefer in the docstring
| LOG_DATA = "log_data" | ||
|
|
||
|
|
||
| class LogSender(Widget): |
There was a problem hiding this comment.
since this component only works in client, what happen if users put this in server side?
Do we need some checking against that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add storage capability for client logs and allow for use with LogSender and LogReceiver.
Description
To use this, add this component to the resources on the client site:
{
"id": "log_sender",
"path": "nvflare.app_common.widgets.log_streaming.LogSender",
"args": {}
},
and with this configured on the server:
{
"id": "log_receiver",
"path": "nvflare.app_common.widgets.log_streaming.LogReceiver",
"args": {}
},
Types of changes
./runtest.sh.