CC authorizers #3052
Open
CC authorizers #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| count = count + 1 | ||
| try: | ||
| r = requests.post( | ||
| "http://localhost:8284/attest/maa", |
There was a problem hiding this comment.
what is this ? localhost:8284 ?
| token = r.json().get("token") | ||
| break | ||
| except: | ||
| if count > 5: |
There was a problem hiding this comment.
should 5 be CONSTANT variable, so it can easily changed or configured
| except: | ||
| if count > 5: | ||
| break | ||
| time.sleep(2) |
There was a problem hiding this comment.
2 sec be a constant variable
|
|
||
| .. code-block:: json | ||
| GPU_NAMESPACE = "x-nv-gpu" |
There was a problem hiding this comment.
why hard code this string in the code, should be this be a policy file to be signed ?
| super().__init__() | ||
| self.verifiers = verifiers | ||
| class GPUAuthorizer(CCAuthorizer): | ||
| def __init__(self, verifier_url="https://nras.attestation.nvidia.com/v1/attest/gpu", policy_file=None): |
There was a problem hiding this comment.
should we make the URL a variable or pass in from configuration. Although the this is unlikely to change, what if the NRAS URL changes (for example, to v2). we should need to change code and reploy code.
| def __init__(self, verifier_url="https://nras.attestation.nvidia.com/v1/attest/gpu", policy_file=None): | ||
| self._can_generate = True | ||
| self.client = attestation.Attestation() | ||
| self.client.set_name("nvflare_node") |
There was a problem hiding this comment.
what is "nvflare_node" ?
chesterxgchen
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CC authorizers, including ACI (Azure Container Instances w/ skr:2.7 for maa token retrieval), GPU (nvtrust), SNP (AMD), TDX (Intel), Mock (always true).
Rebased to main and tested on Azure ACI.
Types of changes
./runtest.sh.