Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance launcher executor #2744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enhance launcher executor #2744

wants to merge 4 commits into from

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

  • Add clear of peer_is_up_or_dead
  • Enhance error messages

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from 02adcf3 to a16b814 Compare July 30, 2024 21:10
@YuanTingHsieh YuanTingHsieh changed the title Enhance launcher executor and subprocess launcher Enhance launcher executor Jul 30, 2024
@YuanTingHsieh YuanTingHsieh changed the title Enhance launcher executor [2.6] Enhance launcher executor Jul 30, 2024
yanchengnv
yanchengnv requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Please improve log message text.

nvflare/app_common/executors/launcher_executor.py Outdated Show resolved Hide resolved
nvflare/app_common/executors/launcher_executor.py Outdated Show resolved Hide resolved
nvflare/app_common/executors/launcher_executor.py Outdated Show resolved Hide resolved
@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from b5cb345 to a131bb1 Compare November 25, 2024 23:06
@YuanTingHsieh YuanTingHsieh changed the title [2.6] Enhance launcher executor Enhance launcher executor Nov 25, 2024
@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from a131bb1 to 1d8da0a Compare November 25, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @yanchengnv