Skip to content

Commit

Permalink
Fix Triton build again (#899)
Browse files Browse the repository at this point in the history
AMD headers are included unconditionally; the simplest approach is to
make sure they exist.
  • Loading branch information
olupton authored Jun 14, 2024
1 parent b4d6332 commit 9ed1582
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/container/Dockerfile.triton
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ sed -i -e 's|-Werror||g' CMakeLists.txt
sed -i -e 's|\(LLVMAMDGPU.*\)|# \1|g' CMakeLists.txt
# Do not build tests
sed -i -e 's|^\s*add_subdirectory(unittest)|# unit tests disabled|' CMakeLists.txt
# Do not build the AMD GPU backend
sed -i -e 's|BackendInstaller.copy(\["nvidia", "amd"\])|BackendInstaller.copy(["nvidia"])|g' python/setup.py
# Google has patches that mess with include paths in source files
sed -i -e '/include_directories(${PROJECT_SOURCE_DIR}\/third_party)/a include_directories(${PROJECT_SOURCE_DIR}/third_party/amd/include)' CMakeLists.txt
sed -i -e '/include_directories(${PROJECT_BINARY_DIR}\/third_party)/a include_directories(${PROJECT_BINARY_DIR}/third_party/amd/include)' CMakeLists.txt
sed -i -e '/include_directories(${PROJECT_SOURCE_DIR}\/third_party)/a include_directories(${PROJECT_SOURCE_DIR}/third_party/nvidia/include)' CMakeLists.txt
sed -i -e '/include_directories(${PROJECT_BINARY_DIR}\/third_party)/a include_directories(${PROJECT_BINARY_DIR}/third_party/nvidia/include)' CMakeLists.txt
# Extra patches to Triton maintained in XLA. These are already applied in the working directory.
Expand Down

0 comments on commit 9ed1582

Please sign in to comment.