Skip to content

Commit

Permalink
Fix docker tags for nightly upstream pax and t5x tests (#296)
Browse files Browse the repository at this point in the history
The containers used to run nightly Pax and T5X upstream mgmn tests were
not updated following the container renaming, so the nightly tests were
erroneously using the rosetta-{pax, t5x} containers. This caused a test
failure with today's Pax nightly because the upstream tests ran with
yesterday's rosetta-pax container, which had an outdated version of
`test-pax.sh`.
  • Loading branch information
ashors1 authored Oct 12, 2023
1 parent dc19036 commit 7544365
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/_test_pax.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:
inputs:
PAX_IMAGE:
type: string
description: PAX image from ghcr.io/nvidia/pax
default: latest
description: PAX image from ghcr.io/nvidia
default: ghcr.io/nvidia/upstream-pax:latest
required: false
EXTRA_TEST_ARGS:
type: string
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_test_pax_rosetta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
PAX_IMAGE:
type: string
description: PAX image from ghcr.io/nvidia/pax
default: latest
default: ghcr.io/nvidia/pax:latest
required: false
EXTRA_TEST_ARGS:
type: string
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/_test_t5x.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:
inputs:
T5X_IMAGE:
type: string
description: T5X image from ghcr.io/nvidia/t5x
default: 'ghcr.io/nvidia/t5x:latest'
description: T5X image from ghcr.io/nvidia
default: 'ghcr.io/nvidia/upstream-t5x:latest'
required: false
BATCH_SIZE_PER_GPU:
type: number
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly-pax-test-mgmn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
PAX_IMAGE:
type: string
description: Pax container
default: 'ghcr.io/nvidia/pax:latest'
default: 'ghcr.io/nvidia/upstream-pax:latest'
required: true
PUBLISH:
type: boolean
Expand All @@ -25,7 +25,7 @@ permissions:
issues: write # to create issues

env:
DEFAULT_PAX_IMAGE: 'ghcr.io/nvidia/pax:latest'
DEFAULT_PAX_IMAGE: 'ghcr.io/nvidia/upstream-pax:latest'

jobs:

Expand Down Expand Up @@ -165,4 +165,4 @@ jobs:
runs-on: ubuntu-latest
if: (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'failure') && github.event_name != 'workflow_dispatch'
steps:
- run: echo 'Upstream workflow failed, aborting run' && exit 1
- run: echo 'Upstream workflow failed, aborting run' && exit 1
6 changes: 3 additions & 3 deletions .github/workflows/nightly-t5x-test-mgmn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
T5X_IMAGE:
type: string
description: T5X container
default: 'ghcr.io/nvidia/t5x:latest'
default: 'ghcr.io/nvidia/upstream-t5x:latest'
required: true
PUBLISH:
type: boolean
Expand All @@ -25,7 +25,7 @@ permissions:
issues: write # to create issues

env:
DEFAULT_T5X_IMAGE: 'ghcr.io/nvidia/t5x:latest'
DEFAULT_T5X_IMAGE: 'ghcr.io/nvidia/upstream-t5x:latest'

jobs:

Expand Down Expand Up @@ -127,4 +127,4 @@ jobs:
runs-on: ubuntu-latest
if: (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'failure') && github.event_name != 'workflow_dispatch'
steps:
- run: echo 'Upstream workflow failed, aborting run' && exit 1
- run: echo 'Upstream workflow failed, aborting run' && exit 1

0 comments on commit 7544365

Please sign in to comment.