Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DALI proxy option to EfficientNet example #5791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jantonguirao
Copy link
Contributor

Category:

Other

Description:

Add DALI proxy option to EfficientNet example
Add performance check of DALI proxy variant to efficient net performance test

Additional information:

Affected modules and functionalities:

Examples

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

if self._dali_server is not None:
self._dali_server.__exit__(exc_type, exc_value, traceback)

with DALIServerCtx(train_loader), DALIServerCtx(val_loader):

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error documentation

Local variable 'train_loader' may be used before it is initialized.
if self._dali_server is not None:
self._dali_server.__exit__(exc_type, exc_value, traceback)

with DALIServerCtx(train_loader), DALIServerCtx(val_loader):

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error documentation

Local variable 'val_loader' may be used before it is initialized.
with DALIServerCtx(train_loader), DALIServerCtx(val_loader):
train_loop(
trainer,
lr_policy,

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error documentation

Local variable 'lr_policy' may be used before it is initialized.
trainer,
lr_policy,
train_loader,
train_loader_len,

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error documentation

Local variable 'train_loader_len' may be used before it is initialized.
train_loader,
train_loader_len,
val_loader,
logger,

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error documentation

Local variable 'logger' may be used before it is initialized.
train_loader_len,
val_loader,
logger,
start_epoch=start_epoch,

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error documentation

Local variable 'start_epoch' may be used before it is initialized.
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22747398]: BUILD STARTED

Comment on lines 83 to 92
# DALI proxy without automatic augmentations
python multiproc.py --nproc_per_node 8 ./main.py --amp --static-loss-scale 128 --batch-size 512 --workers 13 --epochs 3 --no-checkpoints --training-only --data-backend dali_proxy --automatic-augmentation disabled --workspace $RESULT_WORKSPACE --report-file bench_report_dali_proxy.json $PATH_TO_IMAGENET

# DALI proxy with AutoAugment
python multiproc.py --nproc_per_node 8 ./main.py --amp --static-loss-scale 128 --batch-size 128 --workers 13 --epochs 3 --no-checkpoints --training-only --data-backend dali_proxy --automatic-augmentation autoaugment --workspace $RESULT_WORKSPACE --report-file bench_report_dali_proxy_aa.json $PATH_TO_IMAGENET

# DALI proxy with TrivialAugment
python multiproc.py --nproc_per_node 8 ./main.py --amp --static-loss-scale 128 --batch-size 128 --workers 13 --epochs 3 --no-checkpoints --training-only --data-backend dali_proxy --automatic-augmentation trivialaugment --workspace $RESULT_WORKSPACE --report-file bench_report_dali_proxy_ta.json $PATH_TO_IMAGENET

# -----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is just my preference, can you move it to L70 so we have all cases with DALI grouped together?

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22747398]: BUILD FAILED

@jantonguirao jantonguirao marked this pull request as ready for review January 20, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants