Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rulesets: End to End assignment creation (KHO-172, KHO-173) #162
base: main
Are you sure you want to change the base?
Feature/rulesets: End to End assignment creation (KHO-172, KHO-173) #162
Changes from 15 commits
b70bbf1
628f4fe
1714afe
c8b845c
77d2198
29f03e2
a8fc053
003a7df
2dec48b
d0f3767
c49635d
34b83b3
5c38e2d
19aa4e8
1a3b5c0
31ceedb
83f0428
562739c
f5895c9
bcec954
7a73477
9cd3763
9561288
826dbfa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different than GitHubAPI error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to have this one in the intermediary stage before I can properly implement the recovery process.
In my mind this is an error that should not be thrown in any case, and probably represents a panic state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take in
DestinationBranch
as a parameter. It will not always bemain
(master
, for example). Can be dynamically determined withpushEvent.Repo.MasterBranch
in webhooks file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above for
CreateDeadlineEnforcement
andCreatePREnforcement
withEditRepository
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved w struct usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅