-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded Examine Experiment [DO NOT MERGE] #853
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1690,6 +1690,8 @@ window "mapwindow" | |
on-size = "" | ||
icon-size = 0 | ||
text-mode = false | ||
letterbox = true | ||
zoom = 0 | ||
on-show = ".winset\"mainwindow.mainvsplit.left=mapwindow\"" | ||
on-hide = ".winset\"mainwindow.mainvsplit.left=\"" | ||
style = "" | ||
|
@@ -2134,7 +2136,7 @@ window "infowindow" | |
elem "info" | ||
type = INFO | ||
pos = 0,0 | ||
size = 638x475 | ||
size = 636x451 | ||
anchor1 = 0,0 | ||
anchor2 = 100,100 | ||
font-family = "" | ||
|
@@ -2157,9 +2159,11 @@ window "infowindow" | |
tab-font-family = "" | ||
tab-font-size = 0 | ||
tab-font-style = "" | ||
allow-html = false | ||
allow-html = true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Umm, what's going on here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By default, HTML in stat panels doesn't get parsed. Changing this shouldn't cause any issues since I don't think people would write in html if they didn't want to, and the worse outcome is colored text. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's what I was afraid this let people do, Worst outcome is coloured text? If it allows HTML for coloured text, it allows Scripts to be injected leading to all sorts of exploits. I can't allow this. This has the potential to be DANGEROUS. To the players online, and to SoS. You will find a different way to display your text without using HTML or this experiment ends here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^ yes this html exploits are super easy There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't this vulnerability already exist as the output box supports HTML? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Which output box? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The main chat one. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as I said in the IRC last night, I believe that's setup to strip HTML. |
||
multi-line = true | ||
on-show = ".winset\"rpane.infob.is-visible=true;rpane.browseb.is-visible=true?rpane.infob.pos=130,0:rpane.infob.pos=65,0 rpane.textb.is-visible=true rpane.infob.is-checked=true rpane.rpanewindow.pos=0,30 rpane.rpanewindow.size=0x0 rpane.rpanewindow.left=infowindow\"" | ||
on-hide = ".winset\"rpane.infob.is-visible=false;rpane.browseb.is-visible=true?rpane.browseb.is-checked=true rpane.rpanewindow.left=browserwindow:rpane.textb.is-visible=true rpane.rpanewindow.pos=0,30 rpane.rpanewindow.size=0x0 rpane.rpanewindow.left=\"" | ||
on-tab = "" | ||
prefix-color = none | ||
suffix-color = none | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is commented out, remove it.