Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #370 (energy_from_power returns incorrect index for shifted hourly data) #437

Open
wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Fix issue #370 (energy_from_power returns incorrect index for shifted hourly data) #437

wants to merge 9 commits into from

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Nov 6, 2024 •
edited
Loading

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@martin-springer martin-springer changed the base branch from master to development November 6, 2024 20:35
@martin-springer martin-springer mentioned this pull request Nov 6, 2024
Open
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (596f584) to head (58eab97).

Additional details and impacted files 
@@             Coverage Diff              @@
##           development     #437   +/-   ##
============================================
  Coverage        96.19%   96.19%           
============================================
  Files               11       11           
  Lines             2209     2209           
============================================
  Hits              2125     2125           
  Misses              84       84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mdeceglie
mdeceglie requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good. I suggest we add a test, can just use the example from the issue.

docs/sphinx/source/changelog/v3.0.0-beta.0.rst Outdated
@@ -31,6 +31,7 @@ Bug fixes
* Deploy workflow was replaced with trusted publisher workflow for pypi (:pull:`427`)
* Fix pandas 2.0.0 deprications and update syntax changes (:pull:`428`)
* Fix numpy 2.0.0 deprications and update syntax changes (:pull:`428`)
* Fix `energy_from_power`` returns incorrect index for shifted hourly data (:issue:`370`, :pull:`437`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to a pending changelog section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@martin-springer
Copy link
Collaborator Author

The solution looks good. I suggest we add a test, can just use the example from the issue.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeceglie mdeceglie mdeceglie requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-springer @codecov-commenter @mdeceglie