Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to filter arguments for TrendAnalysis (Issue #377) #436

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Nov 6, 2024

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (58b00e1) to head (2479e35).

Files with missing lines Patch % Lines
rdtools/analysis_chains.py 95.34% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #436      +/-   ##
===============================================
- Coverage        96.10%   96.08%   -0.02%     
===============================================
  Files               11       11              
  Lines             2209     2250      +41     
===============================================
+ Hits              2123     2162      +39     
- Misses              86       88       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution works great! Let's add some simple tests for the intended behavior

docs/sphinx/source/changelog/v3.0.0-beta.0.rst Outdated Show resolved Hide resolved
@martin-springer
Copy link
Collaborator Author

The solution works great! Let's add some simple tests for the intended behavior

Done.

@mdeceglie
Copy link
Collaborator

Thank you for adding the unit tests. I suggest we also add some simple tests to the trend analysis as well: checking that every key we think should work does work (including ad_hoc) and checking that some bogus key in either filter_params or filter_params_aggregated raises an error

@martin-springer
Copy link
Collaborator Author

Thank you for adding the unit tests. I suggest we also add some simple tests to the trend analysis as well: checking that every key we think should work does work (including ad_hoc) and checking that some bogus key in either filter_params or filter_params_aggregated raises an error

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants