-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks to filter arguments for TrendAnalysis (Issue #377) #436
base: development
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #436 +/- ##
===============================================
- Coverage 96.10% 96.08% -0.02%
===============================================
Files 11 11
Lines 2209 2250 +41
===============================================
+ Hits 2123 2162 +39
- Misses 86 88 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution works great! Let's add some simple tests for the intended behavior
Done. |
Thank you for adding the unit tests. I suggest we also add some simple tests to the trend analysis as well: checking that every key we think should work does work (including ad_hoc) and checking that some bogus key in either |
added |
__init__.py