Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add citation.cff file #434

Merged
merged 9 commits into from
Dec 18, 2024
Merged

add citation.cff file #434

merged 9 commits into from
Dec 18, 2024

Conversation

martin-springer
Copy link
Collaborator

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@martin-springer martin-springer changed the base branch from master to development October 30, 2024 14:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (a906da8) to head (c34bdef).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #434   +/-   ##
============================================
  Coverage        96.10%   96.10%           
============================================
  Files               11       11           
  Lines             2209     2209           
============================================
  Hits              2123     2123           
  Misses              86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer martin-springer mentioned this pull request Nov 6, 2024
Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to keep maintenance to a minimum, thoughts on removing version number and release date? I am ambivalent about it. If we leave it the same we should consider adding this to the PR checklist so that it doesn't get forgotten with new releases.

@martin-springer
Copy link
Collaborator Author

In order to keep maintenance to a minimum, thoughts on removing version number and release date? I am ambivalent about it. If we leave it the same we should consider adding this to the PR checklist so that it doesn't get forgotten with new releases.

Agreed. I like to keep it simple and removed the version and release date. I've also added Quyen and Noah and updated the reference in the readme.

@martin-springer
Copy link
Collaborator Author

Looks like scikit-learn just had a new release (https://scikit-learn.org/stable/whats_new/v1.6.html#version-1-6-0) and introduced a new tag __sklearn_tags__ that seems to be buggy and makes one of our tests fail.

@mdeceglie
Copy link
Collaborator

Let's use a "pending" section in the change log since 3.0.0b0 is already out.

@martin-springer
Copy link
Collaborator Author

Let's use a "pending" section in the change log since 3.0.0b0 is already out.

Done.

@mdeceglie mdeceglie merged commit 58b00e1 into development Dec 18, 2024
19 checks passed
@mdeceglie mdeceglie deleted the fix_issue_#305 branch December 18, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants