Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set lw to 0 in plotting.degradation_summary_plots #433

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

martin-springer
Copy link
Collaborator

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (596f584) to head (8f327cb).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #433      +/-   ##
===============================================
- Coverage        96.19%   96.10%   -0.10%     
===============================================
  Files               11       11              
  Lines             2209     2209              
===============================================
- Hits              2125     2123       -2     
- Misses              84       86       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but please re-run and commit affected notebooks

@mdeceglie
Copy link
Collaborator

Please also re-run the two trend analysis notebooks, then we should be good to go. Thanks!

@mdeceglie
Copy link
Collaborator

Let's use a "pending" section in the change log since 3.0.0b0 is already out.

@martin-springer
Copy link
Collaborator Author

Please also re-run the two trend analysis notebooks, then we should be good to go. Thanks!

Done.

@martin-springer
Copy link
Collaborator Author

Let's use a "pending" section in the change log since 3.0.0b0 is already out.

Done.

@mdeceglie mdeceglie merged commit d8d0741 into development Dec 18, 2024
19 checks passed
@mdeceglie mdeceglie deleted the fix_issue_#408 branch December 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants