Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated functions #419

Merged
merged 30 commits into from
Jul 3, 2024
Merged

Remove deprecated functions #419

merged 30 commits into from
Jul 3, 2024

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Jun 26, 2024 •
edited
Loading

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • Deprecated functions removed from __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@martin-springer
add test for hour_angle_filter
c390d9b
@martin-springer
add test_directional_tukey_filter
e366176
@martin-springer
add test_insolation_filter
f99a214
@martin-springer
add test_two_way_window_filter
05b0af3
@martin-springer
add bootstrap additive test
dd06d29
@martin-springer
bootstrap_test fix linting
8172208
@martin-springer
run blake
c45d438
@martin-springer
bootstrap test for value error
4c84bdc
@martin-springer
irradiance rescale test for value error
f1378d9
@martin-springer
test for ValueError
b072b57
@martin-springer
flake8 ignore E203
6ac03a1
@martin-springer
add pvlib clearsky filter
73d60c0
@martin-springer
add aggregated filter tests to analysis chain tests
664a7a1
@martin-springer
add missing line
0a11728
@martin-springer
analysis chain hour angle filter test
fb13bac
@martin-springer
liniting
99d4913
@martin-springer
sensor_clearsky_filter vs sensor_pvlib_clearsky_filter
d942380
@martin-springer
update pandocfilters to 1.5.1
42142c2
@martin-springer
restrict numpy<2.0
c6bf396
@martin-springer
CODS testing turn on verbose flag
18e10f7
@martin-springer
remove deprecated sapm_dc_power()
8870cb6
@martin-springer
remove deprecated normalize_with_sapm()
ebb966e
@martin-springer
remove normalize_with_sapm from init
0f4d12c
@martin-springer martin-springer changed the base branch from development to additional-tests June 26, 2024 13:36
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.52%. Comparing base (d1eb662) to head (1a8b45e).

Additional details and impacted files 
@@                        Coverage Diff                        @@
##           aggregated_filters_for_trials     #419      +/-   ##
=================================================================
+ Coverage                          75.25%   75.52%   +0.26%     
=================================================================
  Files                                 13       13              
  Lines                               2825     2807      -18     
=================================================================
- Hits                                2126     2120       -6     
+ Misses                               699      687      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from additional-tests to aggregated_filters_for_trials June 27, 2024 21:07
@mdeceglie mdeceglie merged commit 6ef4a0e into aggregated_filters_for_trials Jul 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeceglie mdeceglie mdeceglie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-springer @codecov-commenter @mdeceglie