Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings for new functions #418

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

mdeceglie
Copy link
Collaborator

@mdeceglie mdeceglie commented Jun 25, 2024

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.25%. Comparing base (8d67b24) to head (ff53213).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           aggregated_filters_for_trials     #418      +/-   ##
=================================================================
+ Coverage                          75.11%   75.25%   +0.14%     
=================================================================
  Files                                 13       13              
  Lines                               2825     2825              
=================================================================
+ Hits                                2122     2126       +4     
+ Misses                               703      699       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdeceglie mdeceglie requested a review from cdeline July 1, 2024 20:18
Copy link
Collaborator

@cdeline cdeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, these API changes look good to me. Thanks!

@mdeceglie mdeceglie merged commit d1eb662 into aggregated_filters_for_trials Jul 2, 2024
16 checks passed
@mdeceglie mdeceglie deleted the doc_updates branch July 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants