Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matt updats to SRR and CODS #417

Merged
merged 46 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
f769327
add two way window filter
mdeceglie Feb 1, 2023
bd73193
provide for insolation based aggregated filters
mdeceglie Feb 1, 2023
2b05fa3
add insolation filter
mdeceglie Feb 1, 2023
069d0cc
bug on insolation filter
mdeceglie Mar 17, 2023
a470db9
add hampel filter
mdeceglie Mar 17, 2023
0fcca8b
add directional tukey filter
mdeceglie Mar 23, 2023
6b24c57
Enable sub-daily aggregation
mdeceglie Mar 24, 2023
03c58e6
add pvlib clearsky filter
mdeceglie Apr 3, 2023
77e14c4
use pvlib_clearsky in TrendAnalysis
mdeceglie Apr 3, 2023
60e18eb
Add sensor_pvlib_clearsky_filter option
mdeceglie Apr 3, 2023
0f670fb
update default filter parameters
mdeceglie Apr 4, 2023
19ff25e
minor typo in error message
cdeline Apr 6, 2023
f12ec96
ensure that clearsky and measured are on same index
mdeceglie Apr 6, 2023
7eec866
remove warnings from logic clip filter
cdeline Apr 26, 2023
d43cb9c
Add control of tukey k
mdeceglie Apr 28, 2023
7e2a81a
fix bug in _call_clearsky_filter
mdeceglie Apr 28, 2023
07d6adf
add pvlib clearsky parameter lookup
mdeceglie Apr 28, 2023
c80c79a
Merge pull request #366 from NREL/365_logic_clipping_warnings
mdeceglie Apr 28, 2023
ea4f68b
bump requirements for hampel filter to work. (maybe other filters to…
cdeline Apr 28, 2023
563dff1
add hour angle filter
mdeceglie May 24, 2023
3bf7363
add hour angle filter to TrendAnalysis
mdeceglie May 24, 2023
04449bc
Merge branch 'master' into hour_angle_filter
mdeceglie May 25, 2023
aa4af78
Merge branch 'master' into aggregated_filters_for_trials
mdeceglie May 25, 2023
54b0423
add hour angle filter
mdeceglie May 24, 2023
ee13551
add hour angle filter to TrendAnalysis
mdeceglie May 24, 2023
9cbcb47
Merge branch 'hour_angle_filter' of https://github.com/NREL/rdtools i…
cdeline May 25, 2023
d94ccba
adjust error message
mdeceglie May 25, 2023
c9285fe
try updating arch version
mdeceglie May 25, 2023
e889ffe
try arch=5.5.0
mdeceglie May 25, 2023
2e689e4
fix broken self.pvlib_location checks.
cdeline May 25, 2023
13d0f9b
Merge branch 'hour_angle_filter' of https://github.com/NREL/rdtools i…
cdeline May 25, 2023
20bc73c
Merge pull request #375 from NREL/hour_angle_filter
mdeceglie May 26, 2023
aa1c007
Merge branch 'development' into aggregated_filters_for_trials
mdeceglie Sep 12, 2023
f22e402
Merge branch 'development' into aggregated_filters_for_trials
mdeceglie Nov 3, 2023
bd52d73
Merge branch 'development' into aggregated_filters_for_trials
mdeceglie Nov 3, 2023
90f31e2
Merge branch 'master' into aggregated_filters_for_trials
mdeceglie Nov 17, 2023
2bd60f4
Merge branch 'development' into aggregated_filters_for_trials
mdeceglie Dec 1, 2023
bc8663a
run tests
martin-springer Apr 3, 2024
13067ff
fix linting
martin-springer Apr 10, 2024
26bb72d
Merge branch 'development' into aggregated_filters_for_trials
mdeceglie Apr 10, 2024
1f25b2f
Wrapper for clearsky filter combining csi and pvlib models (#412)
martin-springer Apr 29, 2024
c8aae89
Matt’s updates to SRR algorithm (detect negative shifts in soiling ra…
Jun 24, 2024
e1401a6
committing updates to merge with aggregated_filters_for_trials
Jul 22, 2024
f23a497
Making sure there will be no merge conflicts
Jul 22, 2024
30f5548
Merge remote-tracking branch 'remotes/origin/aggregated_filters_for_t…
Jul 22, 2024
9e3a411
Improvements in order to pass checks and pytesting
Jul 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 30 additions & 48 deletions docs/TrendAnalysis_example_pvdaq4.ipynb

Large diffs are not rendered by default.

8,315 changes: 4,075 additions & 4,240 deletions docs/degradation_and_soiling_example_pvdaq_4.ipynb

Large diffs are not rendered by default.

26 changes: 13 additions & 13 deletions docs/notebook_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ decorator==4.3.0
defusedxml==0.7.1
entrypoints==0.2.3
html5lib==1.0.1
ipykernel==4.8.2
ipython==8.10.0
ipykernel==6.29.4
ipython==8.23.0
ipython-genutils==0.2.0
ipywidgets==7.3.0
jedi==0.16.0
Jinja2==3.0.0
Jinja2==3.1.3
jsonschema==2.6.0
jupyter==1.0.0
jupyter-client==6.1.7
jupyter-console==6.4.0
jupyter-core==4.11.2
jupyterlab-pygments==0.2.2
jupyter-client==8.6.1
jupyter-console==6.6.3
jupyter-core==5.7.2
jupyterlab-pygments==0.3.0
lxml==4.9.1
MarkupSafe==2.0.0
mistune==2.0.3
Expand All @@ -30,17 +30,17 @@ nbconvert==7.0.0
nbformat==5.1.0
nest-asyncio==1.5.5
notebook==6.4.12
numexpr==2.8.0
pandocfilters==1.4.2
numexpr==2.10.0
pandocfilters==1.5.1
parso==0.5.2
pexpect==4.6.0
pickleshare==0.7.5
prometheus-client==0.3.0
prompt-toolkit==3.0.30
prompt-toolkit==3.0.43
ptyprocess==0.6.0
pycparser==2.20
Pygments==2.15.0
pyzmq==22.2.1
pyzmq==26.0.2
qtconsole==4.3.1
Send2Trash==1.8.0
simplegeneric==0.8.1
Expand All @@ -49,7 +49,7 @@ terminado==0.8.3
testpath==0.3.1
tinycss2==1.1.1
tornado==6.3.3
traitlets==5.0.0
traitlets==5.14.3
wcwidth==0.1.7
webencodings==0.5.1
widgetsnbextension==3.3.0
widgetsnbextension==3.3.0
14 changes: 8 additions & 6 deletions docs/sphinx/source/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ Submodules
==========

RdTools is organized into submodules focused on different parts of the data
analysis workflow.
analysis workflow.

.. autosummary::
:toctree: generated/

analysis_chains
degradation
soiling
soiling
availability
filtering
normalization
Expand All @@ -42,8 +42,8 @@ Object-oriented end-to-end analysis
analysis_chains.TrendAnalysis.plot_soiling_monte_carlo
analysis_chains.TrendAnalysis.plot_pv_vs_irradiance
analysis_chains.TrendAnalysis.plot_degradation_timeseries


Degradation
===========

Expand Down Expand Up @@ -86,7 +86,7 @@ System Availability

.. autosummary::
:toctree: generated/

AvailabilityAnalysis
AvailabilityAnalysis.run
AvailabilityAnalysis.plot
Expand All @@ -100,12 +100,14 @@ Filtering

.. autosummary::
:toctree: generated/

clip_filter
quantile_clip_filter
logic_clip_filter
xgboost_clip_filter
clearsky_filter
csi_filter
pvlib_clearsky_filter
poa_filter
tcell_filter
normalized_filter
Expand Down
1 change: 1 addition & 0 deletions docs/sphinx/source/changelog.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
RdTools Change Log
==================
.. include:: changelog/pending.rst
.. include:: changelog/v2.2.0-beta.2.rst
.. include:: changelog/v2.2.0-beta.1.rst
.. include:: changelog/v2.1.8.rst
Expand Down
27 changes: 27 additions & 0 deletions docs/sphinx/source/changelog/pending.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
*******
pending
*******

Breaking changes
------------
These changes have the potential to change answers in existing scripts
when compared with older versions of RdTools

* Use the pvlib method for clear sky detection by default in :py:func:`~rdtools.analysis_chains.TrendAnalysis` (:pull:`412`)

Enhancements
------------
* Added a new wrapper function for clearsky filters (:pull:`412`)

Bug fixes
---------
* tbd

Requirements
------------
* Specified versions in ``requirements.txt`` and ``docs/notebook_requirements.txt`` have been updated (:pull:`412`)

Contributors
------------
* Martin Springer (:ghuser:`martin-springer`)
* Michael Deceglie (:ghuser:`mdeceglie`)
43 changes: 24 additions & 19 deletions docs/system_availability_example.ipynb

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions rdtools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
from rdtools.degradation import degradation_year_on_year
from rdtools.aggregation import aggregation_insol
from rdtools.clearsky_temperature import get_clearsky_tamb
from rdtools.filtering import clearsky_filter
from rdtools.filtering import csi_filter
from rdtools.filtering import pvlib_clearsky_filter
from rdtools.filtering import poa_filter
from rdtools.filtering import tcell_filter
from rdtools.filtering import clip_filter
Expand Down
4 changes: 2 additions & 2 deletions rdtools/aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def aggregation_insol(energy_normalized, insolation, frequency='D'):
aggregated : pandas.Series
Insolation weighted average, aggregated at frequency
'''
aggregated = (insolation * energy_normalized).resample(frequency).sum() / \
insolation.resample(frequency).sum()
aggregated = (insolation * energy_normalized).resample(frequency, origin='start_day').sum() / \
insolation.resample(frequency, origin='start_day').sum()

return aggregated
Loading
Loading