-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests #413
Add missing tests #413
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aggregated_filters_for_trials #413 +/- ##
=================================================================
+ Coverage 71.70% 75.25% +3.55%
=================================================================
Files 13 13
Lines 2820 2825 +5
=================================================================
+ Hits 2022 2126 +104
+ Misses 798 699 -99 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martin-springer Thanks for putting this together, a few questions but otherwise looks great.
@martin-springer is it possible to re-trigger the codecov report? |
Co-authored-by: Michael Deceglie <[email protected]>
@mdeceglie I do believe so, but haven't done that much myself yet. Looking through the quick start guide (https://docs.codecov.com/docs/quick-start), you can execute the upload of coverage reports from the command line. This page outlines the process (https://docs.codecov.com/docs/codecov-uploader). We might want to tweak the github action, to not only run when a new PR is created but also when commits are made to a PR. This should then take care of it. I can take a look at how we would need to change the config for that. |
This is a draft. Mainly to get Codecov updated.
__init__.py