Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork rubocop 1.50.0 to remove json dependency #89

Merged
merged 1 commit into from
May 14, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 6, 2024

ideally you would fork rubocop onto NREL's umbrella, but whatever, this works for now

rubocop/rubocop@v1.50.0...jmarrec:rubocop:1.50.0-no_json

@jmarrec jmarrec requested a review from wenyikuang May 6, 2024 23:18
@jmarrec jmarrec self-assigned this May 6, 2024
Copy link
Collaborator

@wenyikuang wenyikuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge it after rc2 is released, as rc3

@wenyikuang wenyikuang merged commit 0e84b9a into develop May 14, 2024
5 checks passed
@wenyikuang wenyikuang deleted the rubocop-remove-json branch May 14, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants