Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json: do not export json.a as it doesn't exist #88

Merged
merged 2 commits into from
May 6, 2024
Merged

Json: do not export json.a as it doesn't exist #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6e2b3
Fix json
jmarrec May 6, 2024
8274026
Actually just skip everything for json (the top level one)
jmarrec May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/rubygems_plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ def post_install
elsif extname.to_s == "sqlite3"
extname = "sqlite3_native"
extconf_args = ["--enable-system-libraries", "--with-pkg-config=pkgconf"]
elsif ['unfext', 'byebug', 'generator', 'parser'].include?(extname.to_s)
elsif extname.to_s == 'json'
# json has a makefile, but really it's only json/ext/parser and
# json/ext/generator that are compiled
puts "Not exporting json because it's shallow and doesn't have a static lib (parser and generator do). #{extension_dir.to_s}"
next
wenyikuang marked this conversation as resolved.
Show resolved Hide resolved
elsif ['unfext', 'byebug', 'msgpack', 'generator', 'parser'].include?(extname.to_s)
# No-op
else
puts "Warning: rubygems_plugin.post_install: no configuration given for extension_dir=#{extension_dir}"
Expand Down