Add flag for release candidates gem #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this merge and build I will:
|
jmarrec
reviewed
May 6, 2024
Co-authored-by: Julien Marrec <[email protected]>
|
I don't follow why this is needed. What issue is openstudio-server having? |
jmarrec
requested changes
May 6, 2024
There was a problem hiding this comment.
If there is a release candidate gem on rubygems, just comment out the git: attribute in the normal section
https://rubygems.org/gems/openstudio-standards has 0.6.0-rc2 so all good
THere is no point adding another env var and this complexity.
I suggest just deleting the PR... and use #87
The 5GB size is crashing CI; disk out of space |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with:
export RC_RELEASE=TRUEthe Gemfile will installopenstudio-standardsfrom rubygem.orgexport FINAL_PACKAGE=TRUEthe Gemfile will try to install the gem packages from rubgem.orgWHY:
If we use Gemfile to fetch the gem from github, it will fetch all codebase even if we points to
ref:. In most of the gems it's fine but openstudio-standards' release is only ~500 MB but the code base is ~5GB.Which cause the issue in Openstudio-server.