Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct tap transformer calculation #1034

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Dec 20, 2023

closes #1033

@jd-lara jd-lara requested a review from rodrigomha December 20, 2023 16:56
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (42be5d6) 85.35% compared to head (f34e9aa) 85.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   85.35%   85.33%   -0.03%     
==========================================
  Files         169      169              
  Lines        7649     7659      +10     
==========================================
+ Hits         6529     6536       +7     
- Misses       1120     1123       +3     
Flag Coverage Δ
unittests 85.33% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/parsers/power_models_data.jl 91.38% <66.66%> (-0.95%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jd-lara jd-lara self-assigned this Dec 20, 2023
@jd-lara jd-lara merged commit 06080a9 into main Dec 20, 2023
10 of 11 checks passed
@jd-lara jd-lara deleted the jd/fix_tap_transformer_calculations branch February 5, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-ref transformer parsing issue
2 participants