-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fuel cost time series parameters methods #1164
Draft
rodrigomha
wants to merge
34
commits into
jd/add_thermal_time_series
Choose a base branch
from
rhjd/add_fuelcost_parameter
base: jd/add_thermal_time_series
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add fuel cost time series parameters methods #1164
rodrigomha
wants to merge
34
commits into
jd/add_thermal_time_series
from
rhjd/add_fuelcost_parameter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
reviewed
Oct 16, 2024
src/parameters/add_parameters.jl
Outdated
_add_time_series_parameters!(container, param, devices, model) | ||
ts_type = get_default_time_series_type(container) | ||
if !(ts_type <: Union{PSY.AbstractDeterministic, PSY.StaticTimeSeries}) | ||
error("add_parameters! for TimeSeriesParameter is not compatible with $ts_type") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
error("add_parameters! for TimeSeriesParameter is not compatible with $ts_type") | |
error("add_parameters! for ObjectiveFunctionParameter is not compatible with $ts_type") |
Co-authored-by: jd-lara <[email protected]>
Co-authored-by: jd-lara <[email protected]>
Performance Results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jd/add_thermal_time_series #1164 +/- ##
==============================================================
- Coverage 76.30% 76.18% -0.13%
==============================================================
Files 121 121
Lines 13149 13301 +152
==============================================================
+ Hits 10034 10133 +99
- Misses 3115 3168 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.