Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast_deepcopy_system function #421

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Add fast_deepcopy_system function #421

merged 1 commit into from
Dec 26, 2024

Conversation

GabrielKS
Copy link
Contributor

@GabrielKS GabrielKS commented Dec 24, 2024

This feature supports the PSY implementation of NREL-Sienna/PowerSystems.jl#1231 (i.e., NREL-Sienna/PowerSystems.jl#1234) by adding a function fast_deepcopy_system that makes a deepcopy of a SystemData more quickly by skipping the copying of time series and/or supplemental attributes.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (180ab67) to head (47c4ff6).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   77.75%   78.07%   +0.31%     
==========================================
  Files          69       69              
  Lines        5481     5506      +25     
==========================================
+ Hits         4262     4299      +37     
+ Misses       1219     1207      -12     
Flag Coverage Δ
unittests 78.07% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/system_data.jl 91.80% <100.00%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@daniel-thom daniel-thom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielKS GabrielKS requested a review from jd-lara December 26, 2024 19:12
@jd-lara jd-lara merged commit 77358d9 into main Dec 26, 2024
10 checks passed
@jd-lara jd-lara deleted the gks/fast_deepcopy_system branch December 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants