Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #321

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Fix compiler warnings #321

merged 3 commits into from
Jun 26, 2018

Conversation

ExE-Boss
Copy link
Member

@ExE-Boss ExE-Boss commented Jun 23, 2018

This PR fixes all remaining compiler warnings in the rest of NOVA-Core.

A lot of the warnings were related to either Javadoc or raw types, the rest were unchecked conversion.


Follow up to #278, fixes #184.

Also, the build is painfully slow (see #322).

@ExE-Boss ExE-Boss added enhancement Nice to have features minecraft 1.7 Affects Minecraft 1.7.x wrappers minecraft 1.8 Affects Minecraft 1.8.x wrappers done Pull requests that are finished and are ready to be reviewed and merged labels Jun 23, 2018
@ExE-Boss ExE-Boss added this to the v0.1.0 milestone Jun 23, 2018
@ExE-Boss ExE-Boss self-assigned this Jun 23, 2018
@ExE-Boss ExE-Boss requested review from calclavia and RX14 June 23, 2018 08:47
@codecov-io
Copy link

codecov-io commented Jun 23, 2018

Codecov Report

Merging #321 into master will decrease coverage by 0.02%.
The diff coverage is 13.97%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #321      +/-   ##
============================================
- Coverage     16.99%   16.97%   -0.03%     
  Complexity      965      965              
============================================
  Files           416      416              
  Lines         13165    13176      +11     
  Branches       1383     1382       -1     
============================================
- Hits           2237     2236       -1     
- Misses        10782    10794      +12     
  Partials        146      146
Impacted Files Coverage Δ Complexity Δ
...ava/nova/core/component/transform/Orientation.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../main/java/nova/core/event/bus/EventException.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/nova/core/render/RenderException.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/nova/core/network/NetworkTarget.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...e/wrapper/mc/forge/v18/wrapper/render/BWModel.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...per/mc/forge/v18/wrapper/block/BlockConverter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/nova/core/recipes/ingredient/ItemIngredient.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...e/wrapper/mc/forge/v18/launcher/ForgeLoadable.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...wrapper/mc/forge/v18/asm/lib/TemplateInjector.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../core/wrapper/mc/forge/v17/asm/lib/ObfMapping.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f241f25...bc6f1c9. Read the comment docs.

@ExE-Boss ExE-Boss merged commit 9fc6e96 into master Jun 26, 2018
@ExE-Boss ExE-Boss deleted the fix/compiler-warnings branch June 26, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Pull requests that are finished and are ready to be reviewed and merged enhancement Nice to have features minecraft 1.7 Affects Minecraft 1.7.x wrappers minecraft 1.8 Affects Minecraft 1.8.x wrappers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to remove all compiler warnings
2 participants